Skip to content

fix: eidw change auth flow text #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix: eidw change auth flow text #296

merged 1 commit into from
Aug 14, 2025

Conversation

sosweetham
Copy link
Member

@sosweetham sosweetham commented Aug 13, 2025 •
edited
Loading

Description of change

changes the technically misleading text "stay in app" to "ok"

Issue Number

n/a (294, dont close, has multiple)

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

manual

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Style
    • Updated the button label in the logged-in drawer on the QR scan screen from “Stay in App” to “Ok” to improve clarity and align copy with the rest of the app.
    • Behavior is unchanged: tapping still closes the drawer, navigates to the main screen, and starts scanning.
    • Enhances clarity and consistency across the app, reducing ambiguity for users. No other visible changes.

@sosweetham sosweetham requested a review from coodos as a code owner August 13, 2025 11:35
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 13, 2025 •
edited
Loading

Walkthrough

Renamed the button label in the logged-in drawer within the scan-qr page from “Stay in App” to “Ok”. No logic, control flow, or exported/public signatures were changed.

Changes

Cohort / File(s) Summary of Changes
UI text update
infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte		 Updated button label from “Stay in App” to “Ok”; no functional changes to click handler or navigation/scan behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • coodos

Poem

I thump my paw: a tiny tweak today,
From “Stay in App” to “Ok,” hip-hooray!
QR lights blink, the flow stays true,
Buttons behave, as bunnies do.
A nibble of change, concise and neat—
Hop along, ship complete! 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/eidw-change-dl-text

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (2)

611-621: Optional: Consider a more action-oriented label for clarity and consistency

Since the callback closes the drawer, navigates to /main, and resumes scanning, a label like “Done”, “Back to Wallet”, or “Continue” could reduce ambiguity. Also verify your design system’s capitalization (“OK” vs “Ok”) and localization strategy to ensure consistency.

Example tweak:

-            Ok
+            Done

614-618: Avoid re-starting the scanner right before navigation

Calling startScan() immediately after goto("/main") may briefly reinitialize camera scanning even though we’re leaving the page, which is unnecessary and could cause a visual flash. The onDestroy cleanup will cancel anyway. Consider removing startScan() here.

Proposed change:

             callback={() => {
                 loggedInDrawerOpen = false;
                 goto("/main");
-                startScan();
             }}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b571ab and 3567875.

📒 Files selected for processing (1)
  • infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (1 hunks)
🔇 Additional comments (2)
infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (2)

620-621: Copy change LGTM — clearer and less misleading

“Ok” aligns with the PR intent to avoid the misleading implication of “Stay in App.” No behavioral changes introduced.

620-621: No remaining “Stay in App” instances found

Ripgrep across the entire repository returned zero matches for “stay in app” (case-insensitive) and its common variants, confirming all occurrences have been updated.

@coodos coodos merged commit 828ac4d into main Aug 14, 2025
2 of 4 checks passed
@coodos coodos deleted the fix/eidw-change-dl-text branch August 14, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@coodos coodos coodos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosweetham @coodos